This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
dapps-fetcher: calculate keccak in-flight while reading the response #8294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @sorpaas signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
tomusdrw
approved these changes
Apr 3, 2018
|
Renamed to |
5chdn
added
A7-looksgoodtestsfail 🤖
debris
approved these changes
Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a TODO item in dapps-fetcher.
A new function, called
keccak_buffer_and_writeis added. This allows attaching another BufWrite. When reading the input, it writes it to BufWrite as well. The original functionkeccak_bufferis then just setting the parameter to a Sink.