This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
refactored loading transaction json tests #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let number: Option<u64> = test.block_number.map(Into::into); | ||
| let schedule = match number { | ||
| None => &old_schedule, | ||
| Some(x) if x < 1_000_000 => &old_schedule, |
|
does this whole way of deserialisation now mean that we do an extra set of copies? i.e. JSON -> ethjson::struct, then ethjson::struct -> eth::struct ? that seems rather wasteful if so. |
no values are copied. There are just move operations. |
gavofyork
added
A8-looksgood 🦄
|
looks ok to me (but have't done a deep review - relying on the tests for that :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still todo (in next prs):
FromJsontrait