Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Import geth 1.4.0 keys #872

Merged
merged 1 commit into from
Apr 3, 2016
Merged

Import geth 1.4.0 keys #872

merged 1 commit into from
Apr 3, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Apr 3, 2016

Looks like geth 1.4.0 is standard compliant finally and uses lowercase "crypto" key

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Apr 3, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Apr 3, 2016

https://github.com/ethcore/parity/tree/master/util/res/geth_keystore

would be nice to put examples there to prove it is working

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 3, 2016
@gavofyork
Copy link
Contributor

should also be backported.

@gavofyork gavofyork added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Apr 3, 2016
@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Apr 3, 2016
@gavofyork gavofyork merged commit 8c447dc into master Apr 3, 2016
@gavofyork gavofyork deleted the geth-import branch April 3, 2016 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants