Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Bumping clippy and fixing warnings #889

Merged
merged 3 commits into from
Apr 6, 2016
Merged

Bumping clippy and fixing warnings #889

merged 3 commits into from
Apr 6, 2016

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Apr 6, 2016

Notable new checks:

  1. Types and variables names in docs has to be wrapped in backticks.
  2. Clippy warns about very similar names of variables (which doesn't make sense in couple of cases, like: _lock is very similar to block;))

Other common fixes:

  1. Please use map_or and map_or_else instead of chaining map with unwrap_or or unwrap_or_else respectively
  2. Don't use .iter() -> & is enough.

@tomusdrw tomusdrw added the A0-pleasereview 🤓 Pull request needs code review. label Apr 6, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Apr 6, 2016
@arkpar arkpar merged commit ca17644 into master Apr 6, 2016
@debris debris deleted the clippy branch April 6, 2016 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants