This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Using hyper-mio branch in webapps. #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn on_request(&mut self, req: server::Request) -> Next { | ||
| if let RequestUri::AbsolutePath(ref path) = *req.uri() { | ||
| // Support index file | ||
| if path == &self.prefix || path == &self.prefix2 { |
There was a problem hiding this comment.
could be written more concisely as:
self.path = Some(match path == &self.prefix || path == &self.prefix2 {
true => "index.html",
false => path[self.prefix2.len()..],
}.to_owned());
though perhaps it's more readable if Some(....to_owned()) is duplicated:
self.path = match path == &self.prefix || path == &self.prefix2 {
true => Some("index.html".to_owned()),
false => Some(path[self.prefix2.len()..].to_owned()),
};
gavofyork
added
A6-mustntgrumble 💦
|
needs rebase |
added 2 commits
April 15, 2016 17:14
Conflicts: Cargo.lock parity/main.rs
tomusdrw
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.