From 7a19f55b4cdc82f8880333572a9fb31cab817fb9 Mon Sep 17 00:00:00 2001 From: Tsvetomir Dimitrov Date: Thu, 26 Oct 2023 15:08:48 +0300 Subject: [PATCH] Fixes in `filter_backed_statements` --- .../runtime/parachains/src/paras_inherent/mod.rs | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/polkadot/runtime/parachains/src/paras_inherent/mod.rs b/polkadot/runtime/parachains/src/paras_inherent/mod.rs index f8e369fad02c..2f35d289e722 100644 --- a/polkadot/runtime/parachains/src/paras_inherent/mod.rs +++ b/polkadot/runtime/parachains/src/paras_inherent/mod.rs @@ -1130,16 +1130,17 @@ fn filter_backed_statements( return false } }; - idx += 1; - - filtered = disabled_validators.contains(voted_validator_index); // If we are removing a validity vote - modify `validator_indices` too - if filtered { + let res = if disabled_validators.contains(voted_validator_index) { bc.validator_indices.set(idx, false); - } - - !filtered + filtered = true; + false // drop the validity vote + } else { + true // keep the validity vote + }; + idx += 1; + res }); }