From a3eda0a1bdc67fc14efbf64c1f0046d452f55e31 Mon Sep 17 00:00:00 2001
From: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Date: Mon, 9 Sep 2024 10:34:53 +0200
Subject: [PATCH] [CI] Remove duplicate jobs (#5602)

All of these things are already tested in Github Actions:
https://github.com/paritytech/polkadot-sdk/blob/b3c2a25b73bb4854f26204068f0aec3e8577196c/.github/workflows/checks-quick.yml#L50

Q: the `job-starter` seems to be used by tests, so am keeping it, but
not sure how useful it is.

---------

Co-authored-by: Alexander Samusev <41779041+alvicsam@users.noreply.github.com>
Co-authored-by: alvicsam <alvicsam@gmail.com>
---
 .github/workflows/checks-quick.yml | 26 ++++++++++++++++++++
 .gitlab/pipeline/check.yml         | 39 ------------------------------
 2 files changed, 26 insertions(+), 39 deletions(-)

diff --git a/.github/workflows/checks-quick.yml b/.github/workflows/checks-quick.yml
index ee5ac31e9caa..96f214e9427b 100644
--- a/.github/workflows/checks-quick.yml
+++ b/.github/workflows/checks-quick.yml
@@ -181,3 +181,29 @@ jobs:
         env:
           ASSERT_REGEX: "FAIL-CI"
           GIT_DEPTH: 1
+
+  confirm-required-checks-quick-jobs-passed:
+    runs-on: ubuntu-latest
+    name: All quick checks passed
+    # If any new job gets added, be sure to add it to this array
+    needs:
+      - fmt
+      - check-dependency-rules
+      - check-rust-feature-propagation
+      - test-rust-features
+      - check-toml-format
+      - check-workspace
+      - check-markdown
+      - check-umbrella
+      - check-fail-ci
+    if: always() && !cancelled()
+    steps:
+      - run: |
+          tee resultfile <<< '${{ toJSON(needs) }}'
+          FAILURES=$(cat resultfile | grep '"result": "failure"' | wc -l)
+          if [ $FAILURES -gt 0 ]; then
+            echo "### At least one required job failed ❌" >> $GITHUB_STEP_SUMMARY
+            exit 1
+          else
+            echo '### Good job! All the required jobs passed 🚀' >> $GITHUB_STEP_SUMMARY
+          fi
diff --git a/.gitlab/pipeline/check.yml b/.gitlab/pipeline/check.yml
index 2212c1aeb0a8..7d1f37dddd51 100644
--- a/.gitlab/pipeline/check.yml
+++ b/.gitlab/pipeline/check.yml
@@ -1,25 +1,3 @@
-# from substrate
-# not sure if it's needed in monorepo
-check-dependency-rules:
-  stage: check
-  extends:
-    - .kubernetes-env
-    - .test-refs-no-trigger-prs-only
-  variables:
-    CI_IMAGE: "paritytech/tools:latest"
-  allow_failure: true
-  script:
-    - cd substrate/
-    - ../.gitlab/ensure-deps.sh
-
-test-rust-features:
-  stage: check
-  extends:
-    - .kubernetes-env
-    - .test-refs-no-trigger-prs-only
-  script:
-    - bash .gitlab/rust-features.sh .
-
 job-starter:
   stage: check
   image: paritytech/tools:latest
@@ -29,20 +7,3 @@ job-starter:
   allow_failure: true
   script:
     - echo ok
-
-check-rust-feature-propagation:
-  stage: check
-  extends:
-    - .kubernetes-env
-    - .common-refs
-  script:
-    - zepter run check
-
-check-toml-format:
-  stage: check
-  extends:
-    - .kubernetes-env
-    - .common-refs
-  script:
-    - taplo format --check --config .config/taplo.toml
-    - echo "Please run `taplo format --config .config/taplo.toml` to fix any toml formatting issues"