Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVF: does the kill_parent_node_in_emergency function still work? #2831

Closed
mrcnski opened this issue Jan 1, 2024 · 2 comments
Closed

PVF: does the kill_parent_node_in_emergency function still work? #2831

mrcnski opened this issue Jan 1, 2024 · 2 comments
Assignees
Labels
T0-node This PR/Issue is related to the topic “node”. T10-tests This PR/Issue is related to tests.

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Jan 1, 2024

I definitely tested it as non-root, but that was well before the unsharing stuff was introduced... I should re-test it and get rid of it if it's useless now.

Originally posted by @s0me0ne-unkn0wn in #2643 (comment)

@mrcnski mrcnski added T0-node This PR/Issue is related to the topic “node”. T10-tests This PR/Issue is related to tests. labels Jan 1, 2024
@s0me0ne-unkn0wn s0me0ne-unkn0wn self-assigned this Jan 1, 2024
@s0me0ne-unkn0wn
Copy link
Contributor

I've done some tests and can confirm that kill_parent_node_in_emergency() works as expected. It is unaffected by namespace unsharing as the worker version check is performed before the unsharing takes place. The worker correctly determines the parent node's PID and sends SIGTERM to it; the node then exits gracefully (more or less) thanks to the global signal handler.

So, I believe I can close this issue for now.

@github-project-automation github-project-automation bot moved this from Backlog to Completed in parachains team board Jan 1, 2024
@mrcnski
Copy link
Contributor Author

mrcnski commented Jan 1, 2024

Awesome 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”. T10-tests This PR/Issue is related to tests.
Projects
Status: Completed
Development

No branches or pull requests

2 participants