Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRAME] Warn when using default SubstrateWeights in production #3581

Open
Tracked by #6151
ggwpez opened this issue Mar 5, 2024 · 0 comments
Open
Tracked by #6151

[FRAME] Warn when using default SubstrateWeights in production #3581

ggwpez opened this issue Mar 5, 2024 · 0 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK.

Comments

@ggwpez
Copy link
Member

ggwpez commented Mar 5, 2024 •
edited
Loading

We can probably come up with a cfg clause to add a deprecation to the auto-generated SubstrateWeights to prevent them from accidentally being used in production.
Either by using production profile, on-chain-release-build, std or similar.

Idea came up here.
@kianenigma kianenigma mentioned this issue Mar 29, 2024
Open
@kianenigma kianenigma added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. and removed C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. labels Oct 2, 2024
@kianenigma kianenigma mentioned this issue Oct 2, 2024
Open
@kianenigma kianenigma mentioned this issue Oct 21, 2024
Closed
@kianenigma kianenigma added C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Oct 21, 2024
@kianenigma kianenigma added this to AHM Oct 21, 2024
@kianenigma kianenigma moved this to Backlog in AHM Oct 22, 2024
@kianenigma kianenigma removed this from AHM Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK.
Projects
Benchmarking and Weights
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kianenigma @ggwpez