Get rid of libp2p dependency in sc-authority-discovery

[dmitry-markin]

libp2p types in authority-discovery should be replaced with network backend agnostic types from sc-network-types.

[gotnoshoeson]

I'll have a go at this one

[gotnoshoeson]

So I can remove the libp2p dependency but I'm not quite sure how/where to replace with sc-network-types. I don't see libp2p being used anywhere in the sc-authority-discovery directory.

[bkchr]

If it is not being used, then the pr would just be about removing the crate and that's it ;)

[alexggh]

So I can remove the libp2p dependency but I'm not quite sure how/where to replace with sc-network-types. I don't see libp2p being used anywhere in the sc-authority-discovery directory.

You have to look for re-exported types as well for example the KademliaKey from here: https://github.com/paritytech/polkadot-sdk/blob/master/substrate/client/authority-discovery/src/worker.rs#L45C30-L45C41.

[eagr]

https://github.com/paritytech/polkadot-sdk/blob/master/substrate/client/authority-discovery/src/worker.rs#L171-L190

Worker is a public interface of sc-authority-discovery, which is relying on Record from libp2p. It seems to me ridding libp2p and replacing the type would be a breaking change. That right?

[dmitry-markin]

I don't see these types used in the public API, i.e., in sc_authority_discovery::service::Service.

As for the types used internally (for example, in DhtEvent::ValueFound) — those should be replaced with network-backend-agnostic types put into sc-network-types. The sc-network interface should be updated accordingly.

[ndkazu]

Hello! Started working on this issue, and would like to get a first feedback to see if I'm on the right track:
#5842

[ndkazu]

Working now on removing libp2pdependency from all the tests in sc-authority-discovery.

[ndkazu]

@dmitry-markin , @bkchr : removed libp2p dependencies from sc-authority-discovery. Review needed.