Fix for compatibility with V4 #6503
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgeddes
reviewed
Nov 20, 2024
There was a problem hiding this comment.
Can you be more specific about what the problem is? The element link does not seem to be working for me.
XCMv4 and XCMv5 each have their own NetworkId with different encoding layouts, and they need to be explicitly converted to each other using From or TryFrom traits.
So then surely BH needs to take care to send an XCM to AH that is in the correct format?
acatangiu
approved these changes
Nov 20, 2024
|
The PR makes sense if we have v4::NetworkId entries in storage that we want to directly interpret as v5::NetworkId entries without migrating them. Is this the case? |
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our smoke tests transfer
WETHfrom Sepolia to Westend-AssetHub breaks, try to reregisterWETHon AH but fails as following:https://bridgehub-westend.subscan.io/xcm_message/westend-4796d6b3600aca32ef63b9953acf6a456cfd2fbe
https://assethub-westend.subscan.io/extrinsic/9731267-0?event=9731267-2
The transact call encoded on BH here in V4
can't be decoded on AH with V5.
Issue initial post in https://matrix.to/#/!qUtSTcfMJzBdPmpFKa:parity.io/$RNMAxIIOKGtBAqkgwiFuQf4eNaYpmOK-Pfw4d6vv1aU?via=parity.io&via=matrix.org&via=web3.foundation