From a44bf1009e908de07810ae6719e0c12563395596 Mon Sep 17 00:00:00 2001 From: dastansam Date: Tue, 14 May 2024 17:39:48 +0200 Subject: [PATCH 1/3] Export all public functions of `sc-service` --- substrate/client/service/src/lib.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/substrate/client/service/src/lib.rs b/substrate/client/service/src/lib.rs index d0f315c30c89..2e85ed44fd9f 100644 --- a/substrate/client/service/src/lib.rs +++ b/substrate/client/service/src/lib.rs @@ -54,10 +54,11 @@ use sp_runtime::traits::{Block as BlockT, Header as HeaderT}; pub use self::{ builder::{ - build_network, new_client, new_db_backend, new_full_client, new_full_parts, - new_full_parts_record_import, new_full_parts_with_genesis_builder, new_wasm_executor, - spawn_tasks, BuildNetworkParams, KeystoreContainer, NetworkStarter, SpawnTasksParams, - TFullBackend, TFullCallExecutor, TFullClient, + build_network, gen_rpc_module, init_telemetry, new_client, new_db_backend, new_full_client, + new_full_parts, new_full_parts_record_import, new_full_parts_with_genesis_builder, + new_wasm_executor, propagate_transaction_notifications, spawn_tasks, BuildNetworkParams, + KeystoreContainer, NetworkStarter, SpawnTasksParams, TFullBackend, TFullCallExecutor, + TFullClient, }, client::{ClientConfig, LocalCallExecutor}, error::Error, From 57cf2b4465d6903393e49054d3eda37ccb5f812d Mon Sep 17 00:00:00 2001 From: dastansam Date: Tue, 14 May 2024 17:56:09 +0200 Subject: [PATCH 2/3] Add prdoc --- prdoc/pr_4457.prdoc | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 prdoc/pr_4457.prdoc diff --git a/prdoc/pr_4457.prdoc b/prdoc/pr_4457.prdoc new file mode 100644 index 000000000000..d00c3c8082fe --- /dev/null +++ b/prdoc/pr_4457.prdoc @@ -0,0 +1,15 @@ +# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0 +# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json + +title: "sc-service: export all public functions" + +doc: + - audience: Node Dev + description: | + A PR #3166 converted private functions used in `spawn_tasks()` to public to make it possible to have custom + implementation of the `spawn_tasks()`. However, not all functions were included in the list of exports from + `sc-service` crate. + +crates: + - name: sc-service + bump: patch From ca79cdf552fe0e013dc88c95491dfcb1c2e0c7ee Mon Sep 17 00:00:00 2001 From: Dastan <88332432+dastansam@users.noreply.github.com> Date: Tue, 14 May 2024 20:17:18 +0200 Subject: [PATCH 3/3] Update pr_4457.prdoc Co-authored-by: Oliver Tale-Yazdi --- prdoc/pr_4457.prdoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/prdoc/pr_4457.prdoc b/prdoc/pr_4457.prdoc index d00c3c8082fe..5c9bd9822769 100644 --- a/prdoc/pr_4457.prdoc +++ b/prdoc/pr_4457.prdoc @@ -12,4 +12,4 @@ doc: crates: - name: sc-service - bump: patch + bump: minor