From 1b3805e750398083e386c4041a09124c373d3bd3 Mon Sep 17 00:00:00 2001 From: Morgan Adamiec Date: Tue, 30 Jul 2024 14:20:17 +0100 Subject: [PATCH 1/3] Run semver check even when no prdoc --- .github/workflows/check-semver.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/check-semver.yml b/.github/workflows/check-semver.yml index 7d9fb68b90bf..807e04548556 100644 --- a/.github/workflows/check-semver.yml +++ b/.github/workflows/check-semver.yml @@ -3,8 +3,6 @@ name: Check semver on: pull_request: types: [opened, synchronize, reopened, ready_for_review] - paths: - - prdoc/*.prdoc workflow_dispatch: concurrency: @@ -74,7 +72,7 @@ jobs: - name: install parity-publish # Set the target dir to cache the build. - run: CARGO_TARGET_DIR=./target/ cargo install parity-publish -q + run: CARGO_TARGET_DIR=./target/ cargo install parity-publish@0.8.0 -q - name: check semver run: | From a3202f36baf2d020370be8033d4d7e32e74b5ac5 Mon Sep 17 00:00:00 2001 From: Morgan Adamiec Date: Tue, 30 Jul 2024 15:57:21 +0100 Subject: [PATCH 2/3] Update other parity publish workflows --- .github/workflows/publish-check-crates.yml | 2 +- .github/workflows/publish-claim-crates.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-check-crates.yml b/.github/workflows/publish-check-crates.yml index e627987105a4..9f96b92e0ce7 100644 --- a/.github/workflows/publish-check-crates.yml +++ b/.github/workflows/publish-check-crates.yml @@ -20,7 +20,7 @@ jobs: cache-on-failure: true - name: install parity-publish - run: cargo install parity-publish@0.7.0 + run: cargo install parity-publish@0.8.0 - name: parity-publish check run: parity-publish --color always check --allow-unpublished diff --git a/.github/workflows/publish-claim-crates.yml b/.github/workflows/publish-claim-crates.yml index 167a10a8389b..bee709a12076 100644 --- a/.github/workflows/publish-claim-crates.yml +++ b/.github/workflows/publish-claim-crates.yml @@ -18,7 +18,7 @@ jobs: cache-on-failure: true - name: install parity-publish - run: cargo install parity-publish@0.7.0 + run: cargo install parity-publish@0.8.0 - name: parity-publish claim env: From fbcea408b183cd7aafe117c388f470b7104501a5 Mon Sep 17 00:00:00 2001 From: Morgan Adamiec Date: Tue, 6 Aug 2024 13:41:14 +0100 Subject: [PATCH 3/3] use base instead of hardcoded master --- .github/workflows/check-semver.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check-semver.yml b/.github/workflows/check-semver.yml index 807e04548556..d9d918b44a23 100644 --- a/.github/workflows/check-semver.yml +++ b/.github/workflows/check-semver.yml @@ -22,10 +22,12 @@ jobs: - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7 - name: extra git setup + env: + BASE: ${{ github.event.pull_request.base.sha }} run: | git config --global --add safe.directory '*' - git fetch --no-tags --no-recurse-submodules --depth=1 origin master - git branch old origin/master + git fetch --no-tags --no-recurse-submodules --depth=1 origin $BASE + git branch old $BASE - name: Comment If Backport if: ${{ startsWith(github.event.pull_request.base.ref, 'stable') }}