Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Enable ApprovalCheckingVotingRule on Polkadot #3326

Closed
ordian opened this issue Jun 20, 2021 · 2 comments · Fixed by #4072
Closed

Enable ApprovalCheckingVotingRule on Polkadot #3326

ordian opened this issue Jun 20, 2021 · 2 comments · Fixed by #4072
Assignees
Labels
U2-some_time_soon Issue is worth doing soon.

Comments

@ordian
Copy link
Member

ordian commented Jun 20, 2021

Before we deploy enable parachains runtime on Polkadot

impl primitives::v1::ParachainHost<Block, Hash, BlockNumber> for Runtime {
fn validators() -> Vec<ValidatorId> {
Vec::new()
}
fn validator_groups() -> (Vec<Vec<ValidatorIndex>>, GroupRotationInfo<BlockNumber>) {
(Vec::new(), GroupRotationInfo { session_start_block: 0, group_rotation_frequency: 0, now: 0 })
}
fn availability_cores() -> Vec<CoreState<Hash, BlockNumber>> {
Vec::new()
}
fn persisted_validation_data(_: Id, _: OccupiedCoreAssumption)
-> Option<PersistedValidationData<Hash, BlockNumber>> {
None
}
fn check_validation_outputs(_: Id, _: primitives::v1::CandidateCommitments) -> bool {
false
}
fn session_index_for_child() -> SessionIndex {
0
}
fn session_info(_: SessionIndex) -> Option<SessionInfo> {
None
}
fn validation_code(_: Id, _: OccupiedCoreAssumption) -> Option<ValidationCode> {
None
}
fn candidate_pending_availability(_: Id) -> Option<CommittedCandidateReceipt<Hash>> {
None
}
fn candidate_events() -> Vec<CandidateEvent<Hash>> {
Vec::new()
}
fn dmq_contents(
_recipient: Id,
) -> Vec<InboundDownwardMessage<BlockNumber>> {
Vec::new()
}
fn inbound_hrmp_channels_contents(
_recipient: Id
) -> BTreeMap<Id, Vec<InboundHrmpMessage<BlockNumber>>> {
BTreeMap::new()
}
fn validation_code_by_hash(_hash: ValidationCodeHash) -> Option<ValidationCode> {
None
}
}

we need to revert #3321.

@ordian ordian added U2-some_time_soon Issue is worth doing soon. Q2-easy labels Jun 20, 2021
@ordian ordian added this to the Distant and Unorganized Future milestone Jun 20, 2021
@ordian ordian linked a pull request Jul 21, 2021 that will close this issue
2 tasks
@ordian ordian removed a link to a pull request Jul 21, 2021
2 tasks
@ordian
Copy link
Member Author

ordian commented Sep 8, 2021

after #3815 is merged, but before it's enacted, we'd need a client release with this fix

@rphmeier
Copy link
Contributor

rphmeier commented Sep 8, 2021

I think even after it's enacted is OK. Because there won't be any parachains, the voting rule will still effectively be longest-chain until relay-chain governance actually adds a parachain.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
U2-some_time_soon Issue is worth doing soon.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants