Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Limit dispute votes in the provisioner #4329

Closed
drahnr opened this issue Nov 19, 2021 · 3 comments
Closed

Limit dispute votes in the provisioner #4329

drahnr opened this issue Nov 19, 2021 · 3 comments
Assignees
@tdimitrov
Labels
I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.

Comments

@drahnr
Copy link
Contributor

drahnr commented Nov 19, 2021 •
edited
Loading

Currently dispute vote limiting is done by the block producer as an off-chain call into the runtime of create_inherent. This includes a lot of dispute votes, it's anticipated that we pass a lot more than we'd actually need and hence waste time.

The checks must remain in the runtime's on-chain and off-chain logic, but pre-limiting the votes based on concluded disputes can reduce block production time.

Related #4028
Related #4254
@drahnr drahnr added C1-low PR touches the given topic and has a low impact on builders. I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. and removed C1-low PR touches the given topic and has a low impact on builders. labels Nov 19, 2021
@ordian ordian added the T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance. label Aug 16, 2022
@ordian ordian moved this to To do in Parachains-core Aug 17, 2022
@ordian ordian moved this from To do to In progress in Parachains-core Aug 17, 2022
@sandreim
Copy link
Contributor

@tdimitrov does #5894 also fixes this issue ?

@tdimitrov
Copy link
Contributor

#5894 and #5567 fix this I believe.
For the onchain part there is a separate issue - paritytech/polkadot-sdk#790

@sandreim
Copy link
Contributor

thanks, then I'll close this one

Repository owner moved this from In progress to Done in Parachains-core Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tdimitrov tdimitrov

Labels
I10-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T4-parachains_engineering This PR/Issue is related to Parachains performance, stability, maintenance.
Projects
No open projects
Parachains-core
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tdimitrov @drahnr @ordian @sandreim