Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Weight Trader Comment Incorrect #4815

Closed
apopiak opened this issue Jan 31, 2022 · 4 comments
Closed

Weight Trader Comment Incorrect #4815

apopiak opened this issue Jan 31, 2022 · 4 comments
Labels
I7-documentation Documentation needs fixing, improving or augmenting. T6-XCM This PR/Issue is related to XCM.

Comments

@apopiak
Copy link
Contributor

apopiak commented Jan 31, 2022

polkadot/xcm/xcm-builder/src/weight.rs

Lines 241 to 243 in 5587267

/// Weight trader which uses the `TransactionPayment` pallet to set the right price for weight and then
/// places any weight bought into the right account.
pub struct UsingComponents<

The doc comment seems incorrect, as the transaction payment pallet is not referenced in the implementation and would not fit into any of the configuration types for UsingComponents.

Maybe something like

/// Weight trader which uses the configured `WeightToFee` to set the right price for weight and then 
/// places any weight bought into the right account.

Or depending on what was intended we need to look into how to actually integrate with the transaction payment system.
@apopiak apopiak added I7-documentation Documentation needs fixing, improving or augmenting. Z1-question T6-XCM This PR/Issue is related to XCM. labels Jan 31, 2022
@daredevil3435
Copy link
Contributor

I've corrected it. Please check #6745 PR

@daredevil3435 daredevil3435 mentioned this issue Feb 21, 2023
Merged
@daredevil3435
Copy link
Contributor

@apopiak please check #6745 PR

@apopiak
Copy link
Contributor Author

apopiak commented Feb 23, 2023

@apopiak please check #6745 PR

are you sure? the linked PR talks about something else

@daredevil3435
Copy link
Contributor

daredevil3435 commented Feb 23, 2023 •
edited
Loading

@apopiak please check #6745 PR

are you sure? the linked PR talks about something else

Hey sorry about that I tagged wrong PR. Its #6752

@apopiak apopiak closed this as completed Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I7-documentation Documentation needs fixing, improving or augmenting. T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apopiak @daredevil3435 @the-right-joyce