Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

provisioner: Don't push unconfirmed disputes onchain #6289

Closed
tdimitrov opened this issue Nov 15, 2022 · 1 comment · Fixed by #6294
Closed

provisioner: Don't push unconfirmed disputes onchain #6289

tdimitrov opened this issue Nov 15, 2022 · 1 comment · Fixed by #6294
Assignees
@tdimitrov
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. I4-annoyance Code behaves within expectations, however this “expected behaviour” itself is at issue. T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.

Comments

@tdimitrov
Copy link
Contributor

provisioner should ignore any unconfirmed disputes when generating inherent data.

Currently there are two algorithms for selecting disputes/dispute votes - prioritized selection and random selection. The change should affect both of them.
@tdimitrov tdimitrov added I4-annoyance Code behaves within expectations, however this “expected behaviour” itself is at issue. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. labels Nov 15, 2022
@tdimitrov tdimitrov self-assigned this Nov 15, 2022
@tdimitrov tdimitrov moved this to To do in Parachains-core Nov 15, 2022
@tdimitrov tdimitrov moved this from To do to In progress in Parachains-core Nov 15, 2022
@tdimitrov tdimitrov mentioned this issue Nov 15, 2022
Merged
@tdimitrov
Copy link
Contributor Author

Some clarifications:

  • In random selection unconfirmed disputes are dropped unconditionally.
  • In prioritized_selection we drop unconfirmed disputes only if they are not already onchain. Otherwise we prefer to push fresh votes for them so that they conclude faster.

Repository owner moved this from In progress to Done in Parachains-core Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tdimitrov tdimitrov

Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. I4-annoyance Code behaves within expectations, however this “expected behaviour” itself is at issue. T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
No open projects
Parachains-core
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provisioner should ignore unconfirmed disputes paritytech/polkadot
1 participant
@tdimitrov