Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove spam slots from runtime #6331

Closed
tdimitrov opened this issue Nov 22, 2022 · 0 comments · Fixed by #6345
Closed

Remove spam slots from runtime #6331

tdimitrov opened this issue Nov 22, 2022 · 0 comments · Fixed by #6345
Assignees
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.

Comments

@tdimitrov
Copy link
Contributor

tdimitrov commented Nov 22, 2022

Changes are required in paras-inherent pallet
1.Filter out unconfirmed disputes during vote import - we don't want to record a dispute onchain until we are sure it is a valid one.
2. Never create a block with a dispute containing less votes than needed for confirmation.
3. Remove spam slots and all related configuration options.

Why we want this? Spam slots' purpose is to prevent malicious validators to push spam votes to the runtime and occupy precious block space. At the same time the slots occupy block space by themselves and complicate the dispute processing. If we guarantee that only confirmed disputes are imported onchain we take the best from both world - simple processing, less space occupied, no spam.

@tdimitrov tdimitrov self-assigned this Nov 22, 2022
@tdimitrov tdimitrov added the T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes. label Nov 22, 2022
@tdimitrov tdimitrov moved this to To do in Parachains-core Nov 22, 2022
@tdimitrov tdimitrov moved this from To do to In progress in Parachains-core Nov 22, 2022
@eskimor eskimor removed this from Parachains-core Dec 5, 2022
@eskimor eskimor moved this to In Progress in Disputes + Slashing + Rewards Dec 5, 2022
@github-project-automation github-project-automation bot moved this from In Progress to Done in Disputes + Slashing + Rewards Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T5-parachains_protocol This PR/Issue is related to Parachains features and protocol changes.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant