You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
In #6161, a new structure called PvfWithExecutorParams was designed to carry exhaustive information needed by the executor to execute a PVF. However, its older sibling, called Pvf, is still there, as global refactoring was out of the scope of the original PR. Therefore, we need to research if the Pvf structure has become redundant indeed, and if it is, get rid of it and use PvfWithExecutorParams everywhere.
It is also worth noting that in most cases, there's no need to pass ExecutorParams by value (as a standalone structure or encapsulated into PvfWithExecutorParams). On its way to the executor, it gets SCALE-encoded and recreated on another end several times, so it would be safe to have an Arc reference to it instead of passing everywhere by value.
The text was updated successfully, but these errors were encountered:
In #6161, a new structure called
PvfWithExecutorParams
was designed to carry exhaustive information needed by the executor to execute a PVF. However, its older sibling, calledPvf
, is still there, as global refactoring was out of the scope of the original PR. Therefore, we need to research if thePvf
structure has become redundant indeed, and if it is, get rid of it and usePvfWithExecutorParams
everywhere.It is also worth noting that in most cases, there's no need to pass
ExecutorParams
by value (as a standalone structure or encapsulated intoPvfWithExecutorParams
). On its way to the executor, it gets SCALE-encoded and recreated on another end several times, so it would be safe to have anArc
reference to it instead of passing everywhere by value.The text was updated successfully, but these errors were encountered: