Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Always pass a PVF along with its executor params #6724

Closed
s0me0ne-unkn0wn opened this issue Feb 15, 2023 · 0 comments · Fixed by #6742
Closed

Always pass a PVF along with its executor params #6724

s0me0ne-unkn0wn opened this issue Feb 15, 2023 · 0 comments · Fixed by #6742
Labels
I8-refactor Code needs refactoring.

Comments

@s0me0ne-unkn0wn
Copy link
Contributor

In #6161, a new structure called PvfWithExecutorParams was designed to carry exhaustive information needed by the executor to execute a PVF. However, its older sibling, called Pvf, is still there, as global refactoring was out of the scope of the original PR. Therefore, we need to research if the Pvf structure has become redundant indeed, and if it is, get rid of it and use PvfWithExecutorParams everywhere.

It is also worth noting that in most cases, there's no need to pass ExecutorParams by value (as a standalone structure or encapsulated into PvfWithExecutorParams). On its way to the executor, it gets SCALE-encoded and recreated on another end several times, so it would be safe to have an Arc reference to it instead of passing everywhere by value.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I8-refactor Code needs refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant