Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

PVF: Don't dispute on missing artifact #6959

Closed
mrcnski opened this issue Mar 27, 2023 · 0 comments · Fixed by #7011
Closed

PVF: Don't dispute on missing artifact #6959

mrcnski opened this issue Mar 27, 2023 · 0 comments · Fixed by #7011
Assignees
Labels
J7-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Mar 27, 2023

ISSUE

Overview

A dispute should never be raised if the local cache doesn't provide a certain artifact. You can not dispute based on this reason, as it is a local hardware issue and not related to the candidate to check.

_Originally posted by @bkchr in paritytech/polkadot-sdk#685

Design

Currently we assume that if we prepared an artifact, it remains there on-disk until we prune it, i.e. we never check again if it's still there.

We can change it so that instead of artifact-not-found triggering a dispute, we retry once (like we do for AmbiguousWorkerDeath, except we don't dispute if it still doesn't work). And when enqueuing an execute job, we check for the artifact on-disk, and start preparation if not found.

@mrcnski mrcnski self-assigned this Mar 27, 2023
@mrcnski mrcnski added the J7-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. label Apr 3, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in PVF Security Hardening Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J7-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant