Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

nomination-pools: fix usage of stash and controller around StakingInterface #11440

Closed
kianenigma opened this issue May 17, 2022 · 4 comments
Closed
Labels
Z0-trivial Writing the issue is of the same difficulty as patching the code. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@kianenigma
Copy link
Contributor

currently it is a bit of a mess. It should be aligned with the dispatch origin of the corresponding call. For example, the controller can call bond_extra, so it should be called controller.

@kianenigma kianenigma added Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z0-trivial Writing the issue is of the same difficulty as patching the code. labels May 17, 2022
@kris524
Copy link

kris524 commented May 22, 2022

Hello again, can I pick this task instead? Is there any additional information I might need?

@shawntabrizi
Copy link
Member

We should instead try and drop the controller account logic imo, and just rely on proxies. Seems better than continually iterating on an obsolete api

@kianenigma
Copy link
Contributor Author

cc @ruseinov

@kianenigma
Copy link
Contributor Author

@ruseinov I believe this is closed by #12424 ?

Repository owner moved this from 📕 Backlog to ✅ Done in (Nominated) Proof of Stake Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z0-trivial Writing the issue is of the same difficulty as patching the code. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Status: Done
Development

No branches or pull requests

3 participants