Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove consesus/evaluation.rs? #11700

Closed
bkchr opened this issue Jun 17, 2022 · 0 comments · Fixed by #11766
Closed

Remove consesus/evaluation.rs? #11700

bkchr opened this issue Jun 17, 2022 · 0 comments · Fixed by #11766

Comments

@bkchr
Copy link
Member

bkchr commented Jun 17, 2022

This file contains some initial checks that the block number increased or that we can decode/encode the block. It is questionable if we really to keep to do these checks after build each block. In the end other nodes would reject an invalid block anyway and we don't slash for invalid blocks.

Or we prefer a defensive approach anyway?

Yeah this is mainly defensive, we can probably think about removing all these checks.

Originally posted by @bkchr in #11688 (comment)

@bkchr bkchr added this to SDK Node Jun 17, 2022
@bkchr bkchr moved this to Backlog 🗒 in SDK Node Jun 17, 2022
Repository owner moved this from Backlog 🗒 to Done ✅ in SDK Node Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

1 participant