Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactoring: prepare Peerset for moving connection establishment logic to protocol handlers #13531

Closed
dmitry-markin opened this issue Mar 3, 2023 · 0 comments · Fixed by #13611
Closed

Refactoring: prepare Peerset for moving connection establishment logic to protocol handlers #13531

dmitry-markin opened this issue Mar 3, 2023 · 0 comments · Fixed by #13611
Assignees
@dmitry-markin
Labels
I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon.

Comments

@dmitry-markin
Copy link
Contributor

dmitry-markin commented Mar 3, 2023 •
edited
Loading

Description

This is a preparation task for coming Notifications refactoring outlined in paritytech/polkadot-sdk#556 and split into many tasks.

The main idea is to split peer data storage and connection establishment logic (connect/drop & accept/reject), so that the latter can easily be moved to protocol handlers later.

The connection establishment logic should contain basic heartbeat functionality for establishing new connections that can later be moved to and reused by protocols.

Further steps

The next logical step after this task is researching if (and how) it's possible to move peer addresses from Discovery behavior to the new Peerset data store paritytech/polkadot-sdk#518.
@dmitry-markin dmitry-markin added I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. labels Mar 3, 2023
@dmitry-markin dmitry-markin self-assigned this Mar 3, 2023
@dmitry-markin dmitry-markin moved this to Backlog 🗒 in Networking Mar 3, 2023
@dmitry-markin dmitry-markin mentioned this issue Aug 24, 2023
Open
@altonen altonen mentioned this issue Aug 24, 2023
Closed
@dmitry-markin dmitry-markin moved this from Backlog 🗒 to In Progress 🛠 in Networking Mar 8, 2023
@dmitry-markin dmitry-markin mentioned this issue Mar 15, 2023
Merged
@altonen altonen mentioned this issue Mar 15, 2023
Closed
@github-project-automation github-project-automation bot moved this from In Progress 🛠 to Blocked ⛔️ in Networking May 23, 2023
@altonen altonen moved this from Blocked ⛔️ to Done ✅ in Networking May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmitry-markin dmitry-markin

Labels
I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon.
Projects
Networking
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split Peerset into reputation store & ProtocolControllers paritytech/substrate
1 participant
@dmitry-markin