Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Replace lru with schnellru #13802

Closed
2 tasks done
nazar-pc opened this issue Apr 2, 2023 · 2 comments · Fixed by #14539
Closed
2 tasks done

Replace lru with schnellru #13802

nazar-pc opened this issue Apr 2, 2023 · 2 comments · Fixed by #14539
Labels
J0-enhancement An additional feature request.

Comments

@nazar-pc
Copy link
Contributor

nazar-pc commented Apr 2, 2023

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

Version of lru used right now is old (0.8 instead of current 0.10), also schnellru was introduced as supposedly faster and more featureful replacement.

Request

Replace all usages of lru with schnellru to de-duplicate dependencies

Solution

No response

Are you willing to help with this request?

Maybe (please elaborate above)

@nazar-pc nazar-pc added the J0-enhancement An additional feature request. label Apr 2, 2023
@bkchr
Copy link
Member

bkchr commented Apr 3, 2023

@koute WDYT?

@koute
Copy link
Contributor

koute commented Apr 4, 2023

Yeah, sounds good to me. schnellru should be pretty much a drop-in replacement for lru from a practical point of view.

For performance it probably won't make a difference since I don't think lru is used in any significant hot loops, but it's always nice to get rid of some extra dependencies.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
Status: done
Development

Successfully merging a pull request may close this issue.

3 participants