Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Grandpa consensus affects p2p links #1922

Closed
gguoss opened this issue Mar 5, 2019 · 11 comments
Closed

Grandpa consensus affects p2p links #1922

gguoss opened this issue Mar 5, 2019 · 11 comments
Assignees
Labels
I3-bug The node fails to follow expected behavior.
Milestone

Comments

@gguoss
Copy link
Contributor

gguoss commented Mar 5, 2019

When the finalized of the nodes are inconsistent, the nodes that are finalized are more easily connected.

wechatc659c4bed4f255b3bc13c4f7fc655d47

There are 3 validators in **3992**height, however, only 1 validator in **3990** height. So in **3990** height's validator can't connect other node.

wechat81383614c7481b059439c57ef9f76a04

@rphmeier
Copy link
Contributor

rphmeier commented Mar 5, 2019

cc @arkpar , it may have something to do with block announcements?

Also, it might be a case that the poor connectivity causes the validator to be behind, not the other way around.

@rphmeier rphmeier added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Mar 5, 2019
@gguoss
Copy link
Contributor Author

gguoss commented Mar 7, 2019

image

  • problem 1: listen_addrs: ["/ip4/127.0.0.1/tcp/30333", "/ip4/192.168.1.236/tcp/30333", "/ip4/115.193.183.144/tcp/30333", "/ip4/0.0.0.0/tcp/30333"].
    0.0.0.0 can't listen?

  • problem 2: INFO sync Dropping 1 because "Sent unknown consensus engine id" ,Dropping PeerId(QmSX5KnWLHo5nd3iK6Q99tQEF2v9StAoHQGEb3XY7g3QHk) on purpose (Polkadot CLI and logging initialization. #1, Dialer { address: "/ip4/127.0.0.1/tcp/30333" }, None).
    this peer is god node, can't dropping because unknown consensus engine id?

  • problem 3: INFO substrate Idle (0 peers).
    0 peers can't run gossip?

@gguoss
Copy link
Contributor Author

gguoss commented Mar 7, 2019

image

can't connect 0.0.0.0:port, can reconnect 127.0.0.1:port

@gguoss
Copy link
Contributor Author

gguoss commented Mar 8, 2019

wechat6d09608edf7cd63e948eabfbd7a1bfbc

Validator (auth1, auth2, auth3, auth4)
problem1: In height 17400(Grandpa update authority, deposit log), affect p2p links.

problem2: auth 1~4, p2p connected correct, but height not consistent, (auth3 ,auth4) in 17700 ad spawn block. (auth1 and auth2 ) in 17433 and spawn block.

@gguoss
Copy link
Contributor Author

gguoss commented Mar 8, 2019

auth1.log
17400 is finalized by grandpa. but auth1 continue rollback (< 17400).

@rphmeier rphmeier added I3-bug The node fails to follow expected behavior. and removed J2-unconfirmed Issue might be valid, but it’s not yet known. labels Mar 8, 2019
@gavofyork gavofyork added this to the 1.0 milestone Mar 10, 2019
@rphmeier
Copy link
Contributor

Related to #1944 perhaps

@rphmeier
Copy link
Contributor

@gguoss how does latest master do?

@gguoss
Copy link
Contributor Author

gguoss commented Mar 12, 2019

Before #1944 test.
Now used latest master test , p2p looks good.

@gguoss
Copy link
Contributor Author

gguoss commented Mar 12, 2019

4 validators (A,B,C,D )
A,B,C same finalized height(same round). then start D(D's round < (A or B or C)'s round).

In Mac OS, D can't connect any node,
libp2p-2 INFO sync Dropping 1 because "Sent unknown consensus engine id".
if D not authority, only full node , can sync.

In Ubuntu OS, A, B, C, D 4 validators run ok.

@rphmeier
Copy link
Contributor

@gguoss I'll keep this one open for now -- we are in the middle of some network overhaul to make this better.

@gavofyork gavofyork modified the milestones: 1.0, 1.1 Mar 27, 2019
@arkpar
Copy link
Member

arkpar commented Jul 31, 2019

This is now resolved as far as I know

@arkpar arkpar closed this as completed Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I3-bug The node fails to follow expected behavior.
Projects
None yet
Development

No branches or pull requests

6 participants