Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Structured logging #7019

Open
haikoschol opened this issue Sep 3, 2020 · 2 comments
Open

Structured logging #7019

haikoschol opened this issue Sep 3, 2020 · 2 comments
Labels
J0-enhancement An additional feature request. J2-unconfirmed Issue might be valid, but it’s not yet known.

Comments

@haikoschol
Copy link

haikoschol commented Sep 3, 2020

It would be useful to have structured logging for all messages produced by the node binary (probably opt-in via command line flag). #3260 mentions structured logging, but only in the context of telemetry.
Right now we rely on logstash to turn plain text logs into JSON, which sometimes gets it wrong. A concrete example is a debug message triggering an alert, probably because it contained the string "Error".

@haikoschol haikoschol added the J0-enhancement An additional feature request. label Sep 3, 2020
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Sep 3, 2020
@kianenigma
Copy link
Contributor

Just randomly pinging @sorpaas because of his recent work on logging. Maybe it will be helpful? #6825

@tomaka
Copy link
Contributor

tomaka commented Sep 3, 2020

For what it's worth, the printing is currently done here and here.

It should be quite easy IMO to add a CLI flag that sets the kind of output.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request. J2-unconfirmed Issue might be valid, but it’s not yet known.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants