Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Logging sub-libp2p doesn't work anymore #7251

Closed
tomaka opened this issue Oct 2, 2020 · 3 comments · Fixed by #7281
Closed

Logging sub-libp2p doesn't work anymore #7251

tomaka opened this issue Oct 2, 2020 · 3 comments · Fixed by #7281
Labels
I3-bug The node fails to follow expected behavior.

Comments

@tomaka
Copy link
Contributor

tomaka commented Oct 2, 2020 •
edited
Loading

Doing polkadot --log sub-libp2p doesn't show any of the sub-libp2p logs anymore.

Tried with Substrate master (commit f6c305a)

cc @andresilva @sorpaas
@tomaka tomaka added the I3-bug The node fails to follow expected behavior. label Oct 2, 2020
@bkchr
Copy link
Member

bkchr commented Oct 2, 2020

This is an upstream "bug": tokio-rs/tracing#1012

@tomaka
Copy link
Contributor Author

tomaka commented Oct 5, 2020

Considering that it's the second time that it breaks, I wonder if we should not admit defeat and rename the logging target to sub_libp2p.

@bkchr
Copy link
Member

bkchr commented Oct 5, 2020

I think it is not the only logging target with a dash.

After upstream has released a new version, we should introduce a test to make sure we catch this stuff.

And I also hope that we don't again switch the logging implementation again in the near future.

@bkchr bkchr mentioned this issue Oct 8, 2020
Merged
@ghost ghost closed this as completed in #7281 Oct 8, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I3-bug The node fails to follow expected behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes logging of target names with dashes paritytech/substrate
2 participants
@tomaka @bkchr