This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Use ElectionProvider for pallet-elections-phragmen #8250
Labels
I7-refactor
Code needs refactoring.
Z2-medium
Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Comments
kianenigma
added
I7-refactor
Code needs refactoring.
Z6-mentor
An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Z2-medium
Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
labels
Mar 3, 2021
I'll take a stab at this, might be interesting to be able to move the election offchain. |
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
label
Jul 7, 2021
will take a while, but we want it. |
stale
bot
removed
the
A5-stale
Pull request did not receive any updates in a long time. No review needed at this stage. Close it.
label
Jul 8, 2021
still interesting. |
cc @georgesdib |
kianenigma
removed
the
Z6-mentor
An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
label
Aug 30, 2022
This was referenced Oct 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
I7-refactor
Code needs refactoring.
Z2-medium
Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
Refactor away the entire code of the phragmen election this pallet, and essentially rename it to a generic
pallet-generic-elections
, that can be used with phragmen or whatever else.The very important details here is that this pallet uses the order of
ElectionResult.winners
in the current code, and we need to ensure that in the newElectionProvider::elect()
'sSupports
return type, the order is maintained. Perhaps eachElectionProvider
would implement aconst ORDERED: bool
, and then thepallet-elections
would ensure that it is always true. All in all, we expect to see this new type inpallet-generic-elections
'sConfig
:The text was updated successfully, but these errors were encountered: