Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

--wasm-runtime-overrides does not check spec name #9685

Closed
JoshOrndorff opened this issue Sep 3, 2021 · 0 comments · Fixed by #10380
Closed

--wasm-runtime-overrides does not check spec name #9685

JoshOrndorff opened this issue Sep 3, 2021 · 0 comments · Fixed by #10380
Labels
J0-enhancement An additional feature request.

Comments

@JoshOrndorff
Copy link
Contributor

        --wasm-runtime-overrides <PATH>                          
            Specify the path where local WASM runtimes are stored.
            
            These runtimes will override on-chain runtimes when the version matches.

As the docs say, the runtime version is checked. But it seems the spec name is not checked. On an internal testnet, we recently (accidentally) used a moon_river_ runtime as an override when we should have used a moon_beam_ runtime. As expected, that led to a lot of unintended consequences.

It would be helpful if the spec name was checked and either:

  1. Refuse to use overrides for different runtimes
  2. Print a warning at node startup
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J0-enhancement An additional feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants