Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MultiAddress type for Polkadot config #613

Closed
jsdw opened this issue Aug 5, 2022 · 4 comments
Closed

Fix MultiAddress type for Polkadot config #613

jsdw opened this issue Aug 5, 2022 · 4 comments
Assignees
@tadeohepperle
Labels
ready to implement No significant design questions remain; this can be implemented now

Comments

@jsdw
Copy link
Collaborator

jsdw commented Aug 5, 2022

Our Polkadot config uses MultiAddress<AccountId32, u32> (same as substrate), but looks like it should actually be MultiAddress<AccountId32, ()>. Let's double-check this and make the change.

See #593 (comment)
@jsdw jsdw added this to the v0.24: Tidy and Polish milestone Aug 5, 2022
@jsdw jsdw removed this from the v0.24: Tidy and Polish milestone Aug 16, 2022
@jsdw jsdw added the good first issue Small, well scoped, simple; good for newcomers label Apr 6, 2023
@jsdw
Copy link
Collaborator Author

jsdw commented Apr 6, 2023 •
edited
Loading

So for this, let's:

  • Look at the above link and check that in Polkadot, we should change the MultiAddress type in our subxt::config::PolkadotConfig type (may mean that we'll just copy+paste it from Substrate config and change it rather than using WithExtrinsicParams)
  • Find out what the correct version should be in the Substrate config; maybe it's MultiAddress<AccountId32, ()> in the default substrate node too, so we can just change it for the subxt::config::SubstrateConfig config and then it'll be applied to PolkadotConfig autoamtically anyway.

If you find where the config is defined, please link them here also for clarity :)

@jsdw jsdw added ready to implement No significant design questions remain; this can be implemented now and removed good first issue Small, well scoped, simple; good for newcomers labels Apr 6, 2023
@tadeohepperle tadeohepperle self-assigned this May 2, 2023
@tadeohepperle
Copy link
Contributor

@jsdw Can we close this issue or do we want to investigate it further? The PR was merged.

@niklasad1
Copy link
Member

Yes, I regard it as closed however we may want to open another issue regarding SubstrateConfig vs SubstrateNodeTemplateConfig and #943 (comment) explains it quite well.

@jsdw
Copy link
Collaborator Author

jsdw commented May 4, 2023

Agreed :)

@jsdw jsdw closed this as completed May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadeohepperle tadeohepperle

Labels
ready to implement No significant design questions remain; this can be implemented now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsdw @niklasad1 @tadeohepperle