Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Last-Modified Header #514

Closed
nkranes opened this issue Feb 19, 2016 · 7 comments
Closed

Missing Last-Modified Header #514

nkranes opened this issue Feb 19, 2016 · 7 comments
Labels
type:feature New feature or improvement of existing feature

Comments

@nkranes
Copy link

nkranes commented Feb 19, 2016

I am trying to get 304 Not Modified behavior working through Akamai in front of Parse, but they require both ETags and the Last-Modified header. Is there any reason the Last-Modified header is not coming through. Thanks!

@flovilmart
Copy link
Contributor

You're welcome to provide a Pull Request for that.

@ArKam
Copy link

ArKam commented May 18, 2017

Hey community! I'm currently working on the infrastructures abstraction framework like parse and so would like to start contributing to this project.

As a first light task I could take this one, it's old, doesn't seems to be that difficult, but it have a lack of informations as:

Does you need parse to give you the last-modified headers on each requests globally or do you only need it on some specific endpoint like file object ?

I know that there is a limited set of contributors available and hope to give a hand.
With all the hype about FaaS (or rather named serverless trend) incoming, I think that the parse community can gain interest back at its platform.

@flovilmart
Copy link
Contributor

@ArKam thanks for wanting to contribute. I'm not sure what @nkranes had in mind, but logically, on queries with multiple objects, the last modified would be the most recent updatedAt, and for a single object, just the updatedAt value of such object.

@ArKam
Copy link

ArKam commented May 22, 2017

Hi @flovilmart, nice to read a response on this topic.
Indeed, my question was improperly asked.

I would rather look at the following points:
Does @nkranes is using a mongoDB as the backend for both Files and Objects storage?
Does @nkranes requesting the File API or the Database API?

I am asking that to be able to know what is the scope of the fix and what endpoint should I inspect and fix if needed.

About your own answer, from my experience with object storage backend like S3 or Swift (Openstack) they do send a 304 Not Modified HTTP Response when an object didn't was updated. As it is a defacto way to do things and that most of the biggest CDN like Akamai and CloudFlare are somehow expecting it, I think that I'll try to add this feature.

@montymxb
Copy link
Contributor

Haven't seen any push towards handling 304s lately. @ArKam are you still working on this? I'm closing this out pre-emptively as it seems to have hanged, but if you are let me know and we'll reopen this.

@ArKam
Copy link

ArKam commented Sep 13, 2017

Hi @montymxb I'm really sorry, I didn't had time to work on it, I'll try to have something during my next holidays, for now consider it as close, I'll do a push with this issue ID as soon as I'll get time.

@montymxb
Copy link
Contributor

@ArKam all good, whenever you have time.

@mtrezza mtrezza added type:feature New feature or improvement of existing feature and removed type:improvement labels Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

No branches or pull requests

6 participants