Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveQueryServer doesn't shutdown properly #8424

Closed
4 tasks done
dplewis opened this issue Feb 5, 2023 · 5 comments · Fixed by #8491
Closed
4 tasks done

LiveQueryServer doesn't shutdown properly #8424

dplewis opened this issue Feb 5, 2023 · 5 comments · Fixed by #8491
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed

Comments

@dplewis
Copy link
Member

dplewis commented Feb 5, 2023 •
edited
Loading

New Issue Checklist

Issue Description

There is a flaky test on the JS SDK and I believe it is caused by the liveQueryServer not shutting down when the server shuts down. The server is shutdown but there are still connections to the liveQueryServer. This may have unwanted effects. Also there are flaky tests on the server that could be addressed
https://github.com/parse-community/Parse-SDK-JS/actions/runs/4011772368/jobs/6889651856

Steps to reproduce

  1. Start server with startLiveQueryServer: true configuration
  2. Call server.handleShutdown()
  3. Call server.close()
  4. Check if live query server is still running

Actual Outcome

LiveQueryServer is still opened

Expected Outcome

LiveQueryServer is closed

Alternatives / Workarounds

In production I use a dedicated live query server instead of the internal configuration which is recommended so I never see this issue.

Environment

Server

  • Parse Server version: 6.0.0
  • Operating system: Mac
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): local

Database

  • System (MongoDB or Postgres): Mongo
  • Database version: 4.4
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): local

Client

  • SDK (iOS, Android, JavaScript, PHP, Unity, etc): Javascript
  • SDK version: 4.0.0

Logs
@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 5, 2023 •
edited
Loading

Thanks for opening this issue!

  • 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our Contribution Guide for how to make a pull request, or read our New Contributor's Guide if this is your first time contributing.

@mtrezza mtrezza added the type:bug Impaired feature or lacking behavior that is likely assumed label Feb 6, 2023
@dplewis dplewis mentioned this issue Feb 6, 2023
Closed
@dblythy dblythy mentioned this issue Mar 30, 2023
Merged
1 task
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.1.0-alpha.19

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 8, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jun 10, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0-alpha.1

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version type:bug Impaired feature or lacking behavior that is likely assumed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: LiveQuery server is not shut down properly when handleShutdown is called dblythy/parse-server
3 participants
@mtrezza @dplewis @parseplatformorg