Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl Arrow Flight Protocol for Querying #769

Merged
merged 18 commits into from
May 16, 2024
Merged

Impl Arrow Flight Protocol for Querying #769

merged 18 commits into from
May 16, 2024

Conversation

Eshanatnight
Copy link
Contributor

Fixes #.

Description

Impl Arrow Flight Protocol for Querying

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nitisht nitisht mentioned this pull request Apr 19, 2024
Closed
@Eshanatnight Eshanatnight force-pushed the impl-flight-protocol branch 7 times, most recently from 38b2e24 to b2d3301 Compare April 25, 2024 14:44
@Eshanatnight
Copy link
Contributor Author

Eshanatnight commented Apr 28, 2024 •
edited
Loading

Move Diverging changes to a separate branch. Merge later

@Eshanatnight Eshanatnight marked this pull request as draft April 29, 2024 07:23
@Eshanatnight Eshanatnight force-pushed the impl-flight-protocol branch 2 times, most recently from 3818795 to df7cf18 Compare April 29, 2024 07:24
@Eshanatnight
Copy link
Contributor Author

Query is working with Staging Data.

Edge case, if the staging query is triggered right at the moment object store sync takes place,
the staging data is coming twice. If the we query give or take 5 seconds later it works as intended

@Eshanatnight Eshanatnight force-pushed the impl-flight-protocol branch 2 times, most recently from 932d423 to 8bf842a Compare April 30, 2024 10:52
@Eshanatnight Eshanatnight marked this pull request as ready for review April 30, 2024 12:44
@Eshanatnight Eshanatnight force-pushed the impl-flight-protocol branch from 1eb5330 to 87f2c9d Compare May 2, 2024 06:18
@Eshanatnight Eshanatnight force-pushed the impl-flight-protocol branch from 2069c4f to 5cd4986 Compare May 7, 2024 05:11
@Eshanatnight
fix: bug in sending data more than 4MB
321b0be 
Need to update the `push_logs_unchecked` function as event processing
has changed
Need to clean up the `do_get` function for airplane
@Eshanatnight Eshanatnight force-pushed the impl-flight-protocol branch from 82f2aa9 to 321b0be Compare May 9, 2024 07:59
@Eshanatnight
Copy link
Contributor Author

Should fix #735

@Eshanatnight
fix: response when user gives end time greater than current time
5775e92 
if the user give end time that is greater than `Utc::now()`. Response
was not correct
nikhilsinhaparseable
nikhilsinhaparseable approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge

@nitisht nitisht merged commit f1032cc into parseablehq:main May 16, 2024
7 checks passed
@Eshanatnight Eshanatnight deleted the impl-flight-protocol branch May 16, 2024 06:41
@thinkORo thinkORo mentioned this pull request Jun 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhilsinhaparseable nikhilsinhaparseable nikhilsinhaparseable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eshanatnight @nikhilsinhaparseable @nitisht