Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded types from the PIG domain #510

Closed
alancai98 opened this issue Jan 26, 2022 · 1 comment · Fixed by #755
Closed

Remove hardcoded types from the PIG domain #510

alancai98 opened this issue Jan 26, 2022 · 1 comment · Fixed by #755
Labels
S Small sized task technical debt

Comments

@alancai98
Copy link
Member

alancai98 commented Jan 26, 2022

There are currently some hardcoded types added to the PIG domain. See partiql.ion:

// TODO: Remove these hardcoded nodes from the PIG domain once [https://github.com/partiql/partiql-lang-kotlin/issues/510]
// Elastic Search types
(es_boolean)
(es_integer)
(es_float)
(es_text)
(es_any)
// SPARK Types
(spark_short)
(spark_integer)
(spark_long)
(spark_double)
(spark_boolean)
(spark_float)
// RedShift Types
(rs_varchar_max)
(rs_integer)
(rs_bigint)
(rs_boolean)
(rs_real) // float-32, RS aliases: FLOAT4
(rs_double_precision) // float-64, RS aliases: FLOAT8, FLOAT

These types are temporary and should be removed as soon as possible so users don't take a dependency on these types. Removal of these types may cause downstream changes to AstDeserialization.kt, CustomTypeVisitorTransform.kt, StatementToExprNode, ExprValueType.kt, and SqlParserCustomTypeCatalogTests.kt.

There is no support for these types, beyond parsing and (de)serialization, and we are not aware of currently-active users. The effect of these nodes can be achieved with the generic (custom_type ...) node.

@lziq
Copy link
Contributor

lziq commented Sep 9, 2022

See #755 (comment) for the reason to remove.

@lziq lziq removed this from the Open Type System (OTS) Implementation milestone Sep 13, 2022
@lziq lziq closed this as completed in #755 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S Small sized task technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants