Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXEC allows any token on RHS #707

Closed
johnedquinn opened this issue Aug 17, 2022 · 1 comment
Closed

EXEC allows any token on RHS #707

johnedquinn opened this issue Aug 17, 2022 · 1 comment
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@johnedquinn
Copy link
Member

Description

SqlParser allows ANY token on RHS of Exec. We need to eventually formalize what EXEC should handle on RHS. Likely literal strings, identifiers (quoted and unquoted).

To Replicate

To replicate:

PartiQL> EXEC a
!!
PartiQL> EXEC $
!!
PartiQL> EXEC %
!!
PartiQL> EXEC *
!!
PartiQL> EXEC =
!!

More Information

I'm leaving a TODO in PartiQLParser (experimental) to address this. Since we currently allow any type of token, I will specifically allow expressions that evaluate to strings and identifiers -- since I know we shouldn't be allowing any token.

@johnedquinn johnedquinn added bug Something isn't working good first issue Good for newcomers labels Aug 17, 2022
@johnedquinn johnedquinn self-assigned this Sep 24, 2022
@johnedquinn
Copy link
Member Author

Resolved by #711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant