Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize LIKE pattern compilation #284

Closed
dlurton opened this issue Sep 17, 2020 · 0 comments · Fixed by #286
Closed

Optimize LIKE pattern compilation #284

dlurton opened this issue Sep 17, 2020 · 0 comments · Fixed by #286
Assignees
@dlurton
Labels
performance

Comments

@dlurton
Copy link
Member

dlurton commented Sep 17, 2020 •
edited
Loading

At the moment it takes a pathologically large amount of time and RAM to compile large LIKE patterns.

#279 made the expression 'foo' like '%<n>%' (where '' is 1500 '!' characters) take ~2.6 seconds to compile which is down from ~37 seconds and a big improvement but this is still an order of magnitude too slow. This should take significantly less then that even--into the tens of milliseconds or even less.
@dlurton dlurton mentioned this issue Sep 21, 2020
Merged
dlurton added a commit that referenced this issue Sep 24, 2020
@dlurton
Fast LIKE pattern compilation (#286)
c5d72c0 
Implements #284 

Replaces previous LIKE implementation which is slow when compiling large patterns with wildcard characters `%` with another implementation that compiles the patterns in linear time and has similar performance characteristics at evaluation time.
dlurton added a commit that referenced this issue Sep 29, 2020
@dlurton
Fast LIKE pattern compilation (#286)
9a529b4 
Implements #284

Replaces previous LIKE implementation which is slow when compiling large patterns with wildcard characters `%` with another implementation that compiles the patterns in linear time and has similar performance characteristics at evaluation time.
dlurton added a commit that referenced this issue Sep 29, 2020
@dlurton
Fast LIKE pattern compilation (#286)
5545dba 
Implements #284

Replaces previous LIKE implementation which is slow when compiling large patterns with wildcard characters `%` with another implementation that compiles the patterns in linear time and has similar performance characteristics at evaluation time.
@dlurton dlurton closed this as completed Sep 30, 2020
@dlurton dlurton self-assigned this Sep 30, 2020
@alancai98 alancai98 linked a pull request Sep 30, 2020 that will close this issue
Appropriately fast LIKE pattern compilation #286
Merged
dlurton added a commit that referenced this issue Sep 30, 2020
@dlurton
Fast LIKE pattern compilation (#286)
e80967f 
Implements #284

Replaces previous LIKE implementation which is slow when compiling large
patterns with wildcard characters `%` with another implementation that
compiles the patterns in linear time and has similar performance
characteristics at evaluation time.
@dlurton dlurton mentioned this issue Sep 30, 2020
Merged
dlurton added a commit that referenced this issue Sep 30, 2020
@dlurton
Fast LIKE pattern compilation (#286)
1ff6e84 
Implements #284

Replaces previous LIKE implementation which is slow when compiling large
patterns with wildcard characters `%` with another implementation that
compiles the patterns in linear time and has similar performance
characteristics at evaluation time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlurton dlurton

Labels
performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Appropriately fast LIKE pattern compilation partiql/partiql-lang-kotlin
2 participants
@dlurton @alancai98