Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display synchronization errors #5

Open
riccardomc opened this issue Nov 25, 2020 · 1 comment
Open

Display synchronization errors #5

riccardomc opened this issue Nov 25, 2020 · 1 comment

Comments

@riccardomc
Copy link
Member

We currently only report ERROR state for sync failures and we don't return the actual error message. See this example (UUIDs redacted):

curl -s https://api.poc.parvaeres.io/v1/deployment/... | jq '.Items[0].Errors'
[
  "Failed sync attempt to 68db: one or more synchronization tasks are not valid (retried 5 times)."
]

We could even better than the high level error condition by reporting the syncResult and resources in SyncFailed state.

status:
    conditions:
    - lastTransitionTime: "2020-11-24T21:32:29Z"
      message: 'Failed sync attempt to 68db: one
        or more synchronization tasks are not valid (retried 5 times).'
      type: SyncError
[...]
      phase: Failed
      retryCount: 5
      startedAt: "2020-11-24T21:27:19Z"
      syncResult:
        resources:
        - group: apps.openshift.io
          kind: DeploymentConfig
          message: the server could not find the requested resource
          name: mysql-p07
          namespace: ...
          status: SyncFailed
          syncPhase: Sync
          version: v1
@piyush82
Copy link
Collaborator

piyush82 commented Dec 6, 2020

Now the UI displays the actual error messages. But I noticed that sometimes, even when in error state, no specific error messages are contained in the API response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants