You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Samples of Sequence instances are currently computed in place in the Simulation class and in the _seq_drawer function as well. This gives twopieces of code dedicated to the same task, which is bad.
To 1) fix this 2) ease the construction of the samples dictionary and 3) decouple its use from its construction, it would be very beneficial to implement an independent Sequence sampler component.
Se the original proposal in PR #337.
The sampler will receive a Sequence instance as well as the strategies to sample it: noise sources, qubits masked by an SLM, modulation effects from AOM/EOM. These strategies must play well with each others: they should be easy to add, remove or update independently.
The text was updated successfully, but these errors were encountered:
The SequenceSampler (maybe we should call it this, I'll just adopt the name for now) should be initialised with just the Sequence instance, and then be capable of returning the samples according to the parameters given to its method(s)
I don't know yet if it makes more sense to have a single public method to return the samples (where everything is specified in the arguments or in some configuration parameters) or to have multiple ones. If we are going to distinguish between the sampling for _seq_drawer, then that one would fit well in a separate method, but I don't know if much more splitting makes sense.
Samples of
Sequence
instances are currently computed in place in theSimulation
class and in the_seq_drawer
function as well. This gives two pieces of code dedicated to the same task, which is bad.To 1) fix this 2) ease the construction of the samples dictionary and 3) decouple its use from its construction, it would be very beneficial to implement an independent Sequence sampler component.
Se the original proposal in PR #337.
The sampler will receive a
Sequence
instance as well as the strategies to sample it: noise sources, qubits masked by an SLM, modulation effects from AOM/EOM. These strategies must play well with each others: they should be easy to add, remove or update independently.The text was updated successfully, but these errors were encountered: