-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider deprecating Base64Url #546
Comments
Agreed. We should consider taking a dependency on Microsoft.Bcl.Memory for .NET8.0, and dropping our custom Base64Url reader once it is released in November. The new implementation is vectorized and fuzzed. We may also want to consider taking a dependency on System.Text.Json 9.0 (which cross-targets .NET8.0) after RTM to utilize the built in JsonStringEnumConverter. |
Seems like a good idea. |
It looks like we may also get this dependency pulled in from our depedency on IdentityModel soon, by default. |
As .NET9 will soon ship, I don't think we want to remove Base64Url and force every consumer to upgrade to .net9 as .net 8 is still lts. Perhaps this would be a good v5 issue? |
There is no need to force consumers to migrate to .NET 9. Microsoft.Bcl.Memory is compatible with .NET Standard 2.0. |
So you mean if we upgrade Microsoft.Bcl.Memory we can remove our Base64Url implementation? |
Yes, we just need to upgrade it and use the provided Base64Url implementation. There is no need to update the target framework of Fido2 lib. |
Sounds good! 👍 |
Implemented in #575 |
.NET 9 adds support for Base64 Url (dotnet/runtime#1658). It's also compatible with .NET Standard 2.0. The class Base64Url should probably be deprecated in favor of the built-in support in the BCL.
The text was updated successfully, but these errors were encountered: