Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueError: bbox must be normalized #5

Closed
robert-go opened this issue Jul 15, 2021 · 7 comments
Closed

ValueError: bbox must be normalized #5

robert-go opened this issue Jul 15, 2021 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@robert-go
Copy link

Thanks for your awesome library
I'm trying to recolor iris
But some image have error: ValueError: bbox must be normalized
Here is the google collab to reproduce: https://colab.research.google.com/drive/1UL7F1f-8fyKXBoUg2YcVjAFDN_dfIcIS?usp=sharing

@patlevin patlevin self-assigned this Jul 15, 2021
@patlevin patlevin added the bug Something isn't working label Jul 15, 2021
@patlevin
Copy link
Owner

Thank you for reporting this issue.

The library was a bit too strict with its coordinate system. It didn't anticipate images where not all of the returned face landmarks are actually located within the image (e.g. zoomed-in faces).

This will be fixed in the next release.

@patlevin
Copy link
Owner

The new version with the bugfix is available on PyPi.
Your Google collab example works without errors now after fixing the import error here to:

from fdlite.examples.iris_recoloring import recolor_iris

Many thanks for providing an example for proper repro 👍

@robert-go
Copy link
Author

@patlevin thank you for a quick update
It's worked
Can you update the tutorial to fix import recolor_iris ?
https://github.com/patlevin/face-detection-tflite/blob/main/docs/tutorial.md#fun-with-iris-detection

@patlevin
Copy link
Owner

Can you update the tutorial to fix import recolor_iris ?
https://github.com/patlevin/face-detection-tflite/blob/main/docs/tutorial.md#fun-with-iris-detection

The updated tutorial was part of the latest release - check the link.

@robert-go
Copy link
Author

I mean the import recolor_iris line.
It hasn't been updated yet
Screen Shot 2021-07-16 at 16 31 26

@patlevin
Copy link
Owner

Nice catch! 😄 It's fixed now.

@robert-go
Copy link
Author

Thank you @patlevin
We can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants