Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - Dropdown - popperProps doesn't support appendTo #9565

Closed
wise-king-sullyman opened this issue Sep 1, 2023 · 0 comments · Fixed by #9635
Closed

Bug - Dropdown - popperProps doesn't support appendTo #9565

wise-king-sullyman opened this issue Sep 1, 2023 · 0 comments · Fixed by #9635
Assignees
@wise-king-sullyman
Milestone
2023.Q3

Comments

@wise-king-sullyman
Copy link
Contributor

Describe the problem
Currently we can't customize what the menu appends to in Dropdown without type casting as DropdownPopperProps doesn't support the appendTo property.

How do you reproduce the problem?
Attempt to pass the appendTo property to popperProps and view that it throws a type error requiring type casting.

Expected behavior
A clear and concise description of the expected behavior.
We should be able to pass the appendTo property to popperProps.

This issue will help to properly resolve patternfly/patternfly#5865 in a non-breaking way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wise-king-sullyman wise-king-sullyman

Labels
None yet
Projects
PatternFly Issues
Archived in project
Milestone
2023.Q3
Development

Successfully merging a pull request may close this issue.

fix(Dropdown): Add appendTo to dropdownPopperProps interface wise-king-sullyman/patternfly-react
1 participant
@wise-king-sullyman