diff --git a/.github/workflows/moodle-ci.yml b/.github/workflows/moodle-ci.yml index c3bfec7..2d09354 100644 --- a/.github/workflows/moodle-ci.yml +++ b/.github/workflows/moodle-ci.yml @@ -26,10 +26,12 @@ jobs: moodle-branch: 'MOODLE_402_STABLE' - php: '8.1' moodle-branch: 'MOODLE_403_STABLE' + - php: '8.2' + moodle-branch: 'MOODLE_404_STABLE' steps: - name: Check out repository code - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: path: plugin @@ -68,9 +70,19 @@ jobs: run: moodle-plugin-ci phpunit --fail-on-warning --coverage-text - name: Behat tests + id: behat if: ${{ !cancelled() }} run: moodle-plugin-ci behat --profile chrome + - name: Behat failures + if: ${{ failure() && steps.behat.outcome == 'failure' }} + uses: actions/upload-artifact@v4 + with: + name: Behat failures (${{ join(matrix.*, ', ') }}) + path: ${{ github.workspace }}/moodledata/behat_dump + retention-days: 7 + if-no-files-found: ignore + - name: Mark cancelled jobs as failed if: ${{ cancelled() }} run: exit 1 diff --git a/tests/privacy/provider_test.php b/tests/privacy/provider_test.php index d2bf90f..27ea5be 100644 --- a/tests/privacy/provider_test.php +++ b/tests/privacy/provider_test.php @@ -114,6 +114,6 @@ public function test_export_user_data(): void { $definition = reset($data); $this->assertSame($this->persistent->get_cohort()->name, $definition->cohort); $this->assertSame(role_get_name($this->persistent->get_role(), $context, ROLENAME_ALIAS), $definition->role); - $this->assertObjectHasAttribute('timecreated', $definition); + $this->assertNotEmpty($definition->timecreated); } } diff --git a/version.php b/version.php index 79e435b..706dc01 100644 --- a/version.php +++ b/version.php @@ -25,7 +25,7 @@ defined('MOODLE_INTERNAL') || die(); $plugin->component = 'local_cohortrole'; -$plugin->release = '4.3'; -$plugin->version = 2023121100; +$plugin->release = '4.4'; +$plugin->version = 2024042200; $plugin->requires = 2022112800; // Moodle 4.1 onwards. $plugin->maturity = MATURITY_STABLE;