Release 2.0

[denar90]

• TypeScript usage. Will help us to reduce number of tests and make lib more reliable.
• Yargs - Add yargs #51
• metricsDefinitions - Use lighthouse metricsDefinitions #50 (after Lighthouse release)
• Handle CRI_TIMEOUT error - Handle CRI_TIMEOUT error #42
• test sheets functionality - Sheets imps #38
• refactor/tests for expectations like it was done for sheets Sheets imps #38
• tests for recordLighthouseTrace postponed
• tests for appendResults postponed
• tests for findMedianRun
• refactor/tests for gsheets like it was done for sheets Sheets imps #38
• Remove duplicated pwmetrics object properties and merging yargs support #53, Config file not working #48 (postponed)
• Provide a more meaningful error message in case a tested site is too slow instead of "metric unavailable" #28, pwmetrics is performing only a single round though three rounds were set #31 kinda critical, but depends on lighthouse fix feat: configurable page timeout GoogleChrome/lighthouse#1672

Anything to add, thoughts

[pedro93]

Yargs related tests.
Configuration file parameter validation.

There are also inconsistencies in the README about how to use the config file and certain flags uses. @denar90 if you would like I can talk to you over slack or something and explain.

Edit: As a nice to have we could validate the expectations options. See if the warn criteria is greater or equal to the error message (which is an incorrect use) and similar options like that.

[denar90]

updated priority

[pedro93]

We have promise chains without catch blocks which leads to hidden error messages. These should be cleaned up for a better error processing and logging.

E.g: If we catch an error here, we will not have access to a correct stack trace:

[denar90]

So, the status.
We are about to finish stuff for v2 🎉

In a next few days I'll work on docs, improving it and test all stuff. @pedro93 wanna help me in testing?

---

@paulirish @samccone @pedro93 I prepared some draft article about pwmetrics and it's features, which might help people use it. I'd be glad to hear your thoughts about it. Thx :)

[pedro93]

Sure @denar90, just need a quick rundown of the use cases and i'll start to have a look.

[denar90]

@paulirish let's roll this out 🚀

p.s. will be good to add some topics for repo) nice extensions for chrome - https://github.com/yavorsky/auto-github-topics

[pedro93]

Let's do it! 👍

[paulirish]

because of @samccone's very nice tweet i hustled out a 1.3.1 release that's effectively our 2.0.

it includes a bump to lighthouse and various fixes for that. check https://github.com/paulirish/pwmetrics/commits/master to see them.
afaik it wont have the missing typescript file problems that we have with installing from github.

apologies for shipping "2.0" a tad early, but just wanted to shortcircuit issues like #99.

[paulirish]

@denar90 btw i'm happy to rebump this release as 2.0. i just was doing the fast thing to handle today's traffic. :)

also remind me to tweet out your article!

[denar90]

Yeap, Sam made us react quickly :)
Paul, can you wait about 30 min, I'll manually recheck PR -
#102 so maybe we can land this fix too.
P.S. I've published article about our possibilities https://twitter.com/denar90_/status/854797794829316097

[paulirish]

i just published 1.3.2 which contains:

• the terminal fix
• readme using yarn not npm
• the lighthouse invalidprotoexpectation fix.

[denar90]

🎉 Just woke up and found out that so many stuff is going around.
Do you wanna either release v2 or we will stick to 1.3.x instead?

[paulirish]

i think we should retag as 2.0. i'd love you to take the honors of that. :)

(i've added you as a collaborator on the npm package, so you can publish)

[denar90]

@paulirish thank you for letting me do that!
v2 is landed 🚀
Thanks to all of you guys @paulirish @samccone @pedro93
Cheers 🍺 💃

P.S. If someone is interested in v2 features, we have some article for you https://medium.com/@denar90/easy-progressive-web-metrics-9afa5ed857c2

[pedro93]

AMAZING! 🤗🤗🤗🤗