Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Settings related to Hide greeting and date + Hide time #200

Closed
nomandera opened this issue Nov 18, 2021 · 1 comment · Fixed by #206
Closed

[Feature Request] Settings related to Hide greeting and date + Hide time #200

nomandera opened this issue Nov 18, 2021 · 1 comment · Fixed by #206
Labels
🔨 Feature New feature or request

Comments

@nomandera
Copy link

The current settings only allow hiding both greeting and date together.

To achieve separate hiding you have to allow both but remove the content of Greeting.

Add in time to the mix and its even less intuitive.

Suggest these are relationalsed to three separate simple settings

  • Hide greeting (True false)
  • Hide date (True false)
  • Hide time (True false)

This is elegant and would allow for all variations of setup whilst not having to delete default content such as the stock greetings wording (allowing you to come back to it later without reconfiguring the content).

@pawelmalak pawelmalak added the 🔨 Feature New feature or request label Nov 18, 2021
@pawelmalak pawelmalak linked a pull request Nov 19, 2021 that will close this issue
@nomandera
Copy link
Author

Testing here and all looks perfect to me. Thanks for the consideration and implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants