Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Local Search contains CJK characters are not supported #279

Closed
soulteary opened this issue Jan 4, 2022 · 0 comments · Fixed by #288
Closed

[BUG] Local Search contains CJK characters are not supported #279

soulteary opened this issue Jan 4, 2022 · 0 comments · Fixed by #288
Labels
🐞 Bug Something isn't working

Comments

@soulteary
Copy link
Contributor

Deployment details:

  • App version 2.2.0
  • Platform any
  • Docker image tag 2.2.0

Bug description:

Problem recurring

If the title of bookmark/app set by the user contains non-English characters such as CJK.

image

When users search, they will not get results.

image

Solution

When the user searches locally, the input content is not URL-encoded

image

To solve this problem, I submitted a PR

#278
@soulteary soulteary changed the title [BUG] https://github.com/pawelmalak/flame/pull/278 [BUG] Local Search contains CJK characters are not supported Jan 4, 2022
@pawelmalak pawelmalak added the 🐞 Bug Something isn't working label Jan 8, 2022
@pawelmalak pawelmalak linked a pull request Jan 8, 2022 that will close this issue
Version 2.2.1 #288
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 2.2.1 pawelmalak/flame
2 participants
@soulteary @pawelmalak