-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to keep random people from changing settings #33
Comments
Some user authorization in the app might be a good idea, but you could also secure the whole application using a reverse proxy - if you don't need really public access to flame |
I hadn't considered this issue before now. Previously using Homer which is configured through .yaml without a config page and random people on the internet from changing my settings wasn't an issue so I had no auth set up. I had the thought to just change my reverse proxy's (pomerium) oauth settings to only require authentication on a config page or something. E.g https://domain.me/settings requires authentication via reverse proxy. Which would kind of work except that the add and edit popovers do not have their own URL.
pages but then that would mean that would mean any bookmarks or apps that aren't pinned to the homepage are behind auth as well, and not just the add/edit popovers. Less than ideal but it is better than nothing. EDIT: Doesn't work. If manually navigate to /settings I get prompted for auth but if I click it on the Flame homepage it goes there without auth. |
It will take some time to implement but my idea is as follows:
|
I would like to suggest a different approach if possible, adding a label we can add to the docker-compose file. HIDE-SETTINGS=True/False |
You can also add two environment variables with username and password. Easy for all people. |
I really need this. I don't want to be modified by others. |
My flame install is accessible from the internet, so I would like a possibility to prohibit all the random people on the internet from changing my settings. There are three ways I imagine it could be realized:
The text was updated successfully, but these errors were encountered: