Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor revision constant. #132

Closed
Y-Less opened this issue Jan 20, 2017 · 3 comments
Closed

Minor revision constant. #132

Y-Less opened this issue Jan 20, 2017 · 3 comments

Comments

@Y-Less
Copy link
Member

Y-Less commented Jan 20, 2017

#5 added a new version of __Pawn, which has been useful, but since then this compiler has moved to using 3.10.date for its versions and doesn't bump the minor version at all it seems (which again is fine). However, if there's a fix in one version but not other it would be useful to know (as just discussed in #131). Maybe a BCD __Revision constant such as 0x20170120 (which would be directly comparable for ordering for at least the next 6000 years).

@Zeex Zeex closed this as completed in f96f3b9 Jan 21, 2017
@Zeex
Copy link
Contributor

Zeex commented Jan 21, 2017

Good idea. I went with a plain number instead of a date for simplicity, it will be incremented on each release. The new constant is called __PawnBuild.

@Y-Less
Copy link
Member Author

Y-Less commented Jan 21, 2017

Fair enough, I just suggested the date because that was the scheme you already seemed to be using, but as long as it increases the absolute values don't matter. Thanks.

@Zeex
Copy link
Contributor

Zeex commented Jan 21, 2017

Yeah, I know 😃 This would probably be a patch version if we were following SemVer or could also increment the minor version like you said.

Perhaps something like __PawnVersion which included all 3 fields would be a better solution now that I think about it again, hmm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants