Cache dir and temp dir are not guaranteed to be on the same mount #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is when for example you have a container and have the cache directory bind mounted thus being on a different file system than the temp directory of the container. This makes the os.rename fail. The proposed fix in this merge request just creates the temp directory inside the cache directory next to the values directory. This should not use any additional resources because the tempfile would eventually get in this directory anyway. The only problem I see here is that I don't know a simple way to create a test for this case.