Handle End and Home Keys in list navigation #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, looks like we're just shy of our coverage threshold. Could you give that a look please? |
|
sure, will take a look tomorrow and come back to you. Thanks for the feedback! |
|
I updated a unit test to check that navigation keys (up, down, home, end) do nothing if list is empty. It should maintain the coverage now. You can check :) |
|
Hey @silviuavram, would you be at all interested in being a primary maintainer of the project? Of everyone I feel really comfortable handing this project to you. See #647 |
|
🎉 This PR is included in version 3.1.11 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hello Kent,
Thank you very much for your considering me. It will be both a pleasure and
a challenge to maintain and improve the project.
We are using it currently in our own project, Stardust UI Library, and I am
planning to contribute more to Downshift, as we are finding use cases that
need to be handled and it's way better to improve the source rather than
fixing stuff at our end. It will also be valuable for everyone using the
library.
If you agree to go forward with your decision, I will kindly ask for all
the information you consider necessary and good for me to know. I will also
sync with people from my organisation that have strong knowledge of project
ownership, but your help will also be very valuable.
I look forward to hearing from you.
Best regards,
Silviu
…On Tue, Jan 8, 2019 at 9:00 PM Kent C. Dodds ***@***.***> wrote:
🎉 This PR is included in version 3.1.11 🎉
The release is available on:
- npm package ***@***.*** dist-tag)
- GitHub release
<https://github.com/paypal/downshift/releases/tag/v3.1.11>
Your *semantic-release
<https://github.com/semantic-release/semantic-release>* bot 📦🚀
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#646 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AKwMgKstnYUV0xfXNztBK2Ks_qim42fSks5vBPjJgaJpZM4ZzvzM>
.
|
|
Sounds awesome! Could you shoot me an email and we'll chat about what needs to happen for this to work :) kent@doddsfamily.us |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR aims to improve kb navigation inside the listbox by adding support for
HomeandEnd. These keys should highlight first / last element, if the listbox is visible.Why:
Improves the component by adding another ARIA specification regarding kb navigation.
How:
Added event listeners for keydown on both
HomeandEnd, and added handlers for each, in which I've used variations for thesetHighlightedIndexfunction. Also added event names for both kets.Also added UTs for these changes, and planning to add E2E Cypress tests too. These are already written, however Cypress does not support Home and End at the moment. I've created a PR for implementing this in their repo here. Those tests are currently commented.
Checklist: