You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
What you did:
Add children to named built-in components.
What happened:
index.tsx(90,7): error TS2322: Type '{ children: Element; }' is not assignable to type 'IntrinsicAttributes & CSSProperties & ExtraGlamorousProps & HTMLProps<HTMLDivElement> & { childre...'.
Type '{ children: Element; }' is not assignable to type 'CSSProperties'.
Property 'children' is incompatible with index signature.
Type 'Element' is not assignable to type 'string | number | SingleOrArray<CSSPropertiesCompleteSingle, "alignContent" | "alignItems" | "ali...'.
Type 'Element' is not assignable to type '(string | number | {} | ("inherit" | "initial" | "unset" | "flex-start" | "flex-end" | "center" |...'.```
Reproduction:
Failed to reproduce.
Problem description:
Suggested solution:
It looks like already solved in up-to-date glamorous.
The text was updated successfully, but these errors were encountered:
I am unable to reproduce the problem with the new glamorous version.
Either I messed up the original bug isolation, or there were other differences that have been changed in the meantime. Either way, I think the issue is solved until someone else comes with a similar complaint. Thank you for being so thorough and not dismissing my concerns, @Ailrun.
I had the original problem with glamor@2.20.40, glamorous@4.11.0+#372, react@16.2.0, typescript@2.6.1. Today I am unable to reproduce with glamor@2.20.40, glamorous@4.11.6, react@16.2.0, typescript@2.6.1.
This issue is originally issued by @denis-sokolov.
#372 (comment)
glamorous
version: 4.11.0 + fix(css-properties): remove incorrect React.ReactChild from Lossy Union #372glamor
version: 2.20.40react
version: 16.2.0typescript
version: 2.6.1Relevant code.
What you did:
Add children to named built-in components.
What happened:
Reproduction:
Failed to reproduce.
Problem description:
Suggested solution:
It looks like already solved in up-to-date glamorous.
The text was updated successfully, but these errors were encountered: